feat(ui): manual-scrub replay transport#51
Merged
Conversation
Add a step control to the timeline pane — First / Prev / Next / Last plus a position readout — that walks the current selection through the visible events, reusing the existing select_event message with view-computed target indices. It steps over the filtered set (a hidden event is never selected) and highlights the current event in the timeline exactly as a click would. Entirely a view addition; no Model / Msg / update change. Real wall-clock auto-play needs a timer source the zero-config runner does not expose (spiked), so it stays deferred to the runner-eject bucket (#33). Closes #44.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
feat(ui): the manual-scrub replay transport (S4 #44) — step theselection through the timeline.
Closes #44 (the
ReplayEnginecore landed in #50; this is the closing UI piece).Changes
src/ui/inspector.zig— a transport row atop the timeline pane: First /Prev / Next / Last buttons + an
N / Mposition readout. It reuses theexisting
select_eventMsg with view-computed target indices, so:in the timeline and drives the detail / session / failure panels as usual);
selected, Next → first and Prev → last.
tests), and one small row (no widget-node-budget concern).
Why not wall-clock auto-play
Per the spike (and your call): the zero-config runner exposes no timer/tick effect
(
Command= menu/shortcut commands, not a TEA effect scheduler), so real-timeauto-play is deferred to the runner-eject bucket (#33). This transport is the
manual step/scrub half, which needs no timer.
Tests
117/117 headless tests pass (
native test -Dplatform=null);native check --strictclean;zig fmtclean; the a11y sweep + layout tests still pass. Newcoverage drives the actual buttons (press → Msg → selection moves): First / Prev /
Next / Last stepping, empty-selection behavior, and filter-aware stepping (every
landed selection is a visible CallResult).